Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactoring cleanup from recent PRs #83

Merged
merged 2 commits into from
Aug 11, 2023
Merged

refactoring cleanup from recent PRs #83

merged 2 commits into from
Aug 11, 2023

Conversation

0xabu
Copy link
Owner

@0xabu 0xabu commented Aug 10, 2023

  • don't include '#' in the color hex in every context (why should it be there?)
  • group_highlights_by_color is only used by the grouped markdown printer
  • come up with a cleaner way to implement grouped colours and non-grouped highlights in the same code
  • misc nits

@0xabu
Copy link
Owner Author

0xabu commented Aug 10, 2023

@linozen FYI in case you'd like to take a look / review this: I made some cleanup to your new feature but (hopefully!) no output changes

@0xabu 0xabu merged commit 9496e93 into main Aug 11, 2023
7 checks passed
@0xabu 0xabu deleted the cleanup branch August 11, 2023 07:24
@linozen
Copy link
Contributor

linozen commented Aug 14, 2023

LGTM 👍

Thanks again for this very handy tool and your prompt review of my PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xabu @linozen